Matthias Clasen [Fri, 27 Jan 2023 12:07:36 +0000 (07:07 -0500)]
gl: Synchronize when calling MakeCurrent
When making out GL context current, wait
until the GPU is done with commands from
the previous context.
Fixes: #5517
Matthias Clasen [Wed, 25 Jan 2023 13:09:17 +0000 (13:09 +0000)]
Merge branch 'wip/carlosg/startup-vs-focus-3-24' into 'gtk-3-24'
Consider startup vs focus requests for the Wayland platform [3.24]
See merge request GNOME/gtk!5443
Carlos Garnacho [Wed, 18 Jan 2023 20:05:28 +0000 (21:05 +0100)]
gtkapplication: Do not call gdk_display_notify_startup_complete()
This should do nothing worthwhile anymore, the X11/Wayland GtkApplication
implementations do already pass the startup ID from the platform_data
via windowing specific APIs, and the application handling the request
via show()/present() should trigger the activation request.
(cherry-picked from commit
3526d8b299becb7cd1e970ea5228a141eae20257)
Carlos Garnacho [Wed, 18 Jan 2023 20:01:00 +0000 (21:01 +0100)]
gtkwindow: Shuffle gdk_window_set_startup_id() calls
While this used to be tangential to windows showing or requesting
focus, the xdg-activation Wayland protocol does merge both concepts
together.
But also, for a correct interaction with the compositor, the
toolkit should ideally merge the activation request resulting from
both into the same one, so that the gdk_window_focus() request
replies to the startup token that started the application and
correct focus-stealing prevention/etc happens, instead making up
one just in time for the focus request.
This kind of requires doing things in the right order, a show()
request on the GtkWindow should activate any pending activation
token on the toplevel, a present() request should additionally
create a new token if there was none pending. And
xdg_activation_v1_activate() should happen once on both.
Shuffle the gdk_window_set_startup_id() calls so that this
happens in the right order for Wayland, while making X11 happy
too.
(cherry-picked from commit
e8adfa2a889cd45ee0ce0727d7eae0a61fdb7dce)
Carlos Garnacho [Wed, 18 Jan 2023 19:37:01 +0000 (20:37 +0100)]
gdk/x11: Emit "remove" s-n message from gdk_toplevel_set_startup_id
In the way towards deprecating gdk_display_notify_startup_complete(),
make gdk_toplevel_set_startup_id() on X11 perform this piece of messaging
itself. It should be harmless that the message is emitted twice, if
callers do still use that API.
(cherry-picked from commit
7fab1b85adbddff7628e3e916f00677080fb9150)
Carlos Garnacho [Wed, 18 Jan 2023 19:03:01 +0000 (20:03 +0100)]
gdk/wayland: Perform xdg_activation on gdk_window_set_startup_id
This call has everything to perform activation as specified by the
xdg_activation protocol, notably a surface to activate as opposed to
gdk_notify_startup_complete().
Make activation happen here, so that the surface gets activated when
its gets a startup ID assigned.
(cherry-picked from commit
5aeabdb3d404579b5cab4fff1642ed116f745a8b)
Carlos Garnacho [Wed, 18 Jan 2023 18:55:31 +0000 (19:55 +0100)]
gtkwindow: Minor refactor
Move the handling of the startup ID to a separate function, since
this will be called from several places.
(cherry-picked from commit
6f01f846dc66a6359a1524ace13377536821dbb0)
Matthias Clasen [Sun, 22 Jan 2023 00:01:07 +0000 (00:01 +0000)]
Merge branch 'fix-unscaled-fallback-icon' into 'gtk-3-24'
Take UI scale into acount when loading "image-missing" fallback
See merge request GNOME/gtk!5438
Brian J. Tarricone [Sat, 21 Jan 2023 20:45:09 +0000 (12:45 -0800)]
Take UI scale into acount when loading "image-missing" fallback
Fallback icons loaded were loading at half size (for a 2x scale) and for
cases where it mattered, were being positioned off-center.
Aurimas Černius [Thu, 19 Jan 2023 21:09:54 +0000 (21:09 +0000)]
Update Lithuanian translation
John Ralls [Thu, 19 Jan 2023 18:37:55 +0000 (10:37 -0800)]
[quartz] GdkWindow, GdkNSView frame and cairo surface same size.
The cairo surface must be padded to 4 pixels in order to
transfer correctly to the GPU. The GdkWindow and GdkNSView's
content frame must be the same width, otherwise there's a mismatch
that causes either the GdkWindow to draw wider than the frame or the
frame to be clipped narrower than the title bar.
Fixes #5535.
Matteo Percivaldi [Fri, 13 Jan 2023 20:19:37 +0000 (15:19 -0500)]
gtkcssanimatedstyle: Fix return of new_advance()
This was causing animation and transition to stop randomly and reset
their state to initial state.
This issue has existed since commit
7b68bdb8316fc1bb96c4a5ad16c1885506131d22.
Closes #4426
Emin Tufan Çetin [Wed, 11 Jan 2023 06:57:09 +0000 (06:57 +0000)]
Update Turkish translation
Matthias Clasen [Sun, 8 Jan 2023 12:57:00 +0000 (12:57 +0000)]
Merge branch 'win-file-ext-3-24' into 'gtk-3-24'
Backport "filechoosernativewin32: Set default extension"
See merge request GNOME/gtk!5403
robxnano [Sat, 26 Nov 2022 14:09:40 +0000 (14:09 +0000)]
filechoosernativewin32: Set default extension
Setting the default extension before a filter is selected allows
the IFileDialog to automatically change the extension when the
filter is changed. See:
https://learn.microsoft.com/en-us/windows/win32/api/shobjidl_core/nf-shobjidl_core-ifiledialog-setdefaultextension
John Ralls [Fri, 6 Jan 2023 18:13:02 +0000 (10:13 -0800)]
[quartz] Fix typo to call function.
Nart Tlisha [Thu, 5 Jan 2023 12:36:09 +0000 (12:36 +0000)]
Update Abkhazian translation
Nart Tlisha [Thu, 5 Jan 2023 12:24:58 +0000 (12:24 +0000)]
Update Abkhazian translation
Emmanuele Bassi [Tue, 3 Jan 2023 18:07:17 +0000 (18:07 +0000)]
Merge branch 'fix-4913-for-gtk3' into 'gtk-3-24'
Treat XKB_MOD_NAME_LOGO as super key
See merge request GNOME/gtk!5387
Thomas Jost [Tue, 3 Jan 2023 16:09:04 +0000 (17:09 +0100)]
Treat XKB_MOD_NAME_LOGO as super key
Loosely based on !5304, which fixes #4913 for GTK3.
Thomas Jost [Tue, 3 Jan 2023 15:58:18 +0000 (16:58 +0100)]
tests: make accel tests easier to debug
Matthias Clasen [Tue, 3 Jan 2023 12:29:27 +0000 (12:29 +0000)]
Merge branch 'gtk-3-24' into 'gtk-3-24'
build: Fix build_gir logic
See merge request GNOME/gtk!5371
Staudey [Tue, 27 Dec 2022 04:54:52 +0000 (04:54 +0000)]
Fix build_gir logic
Matthias Clasen [Thu, 22 Dec 2022 13:25:53 +0000 (08:25 -0500)]
3.24.36
Matthias Clasen [Thu, 22 Dec 2022 13:59:12 +0000 (08:59 -0500)]
Revert "Treat XKB_MOD_NAME_LOGO as super key"
This reverts commit
3a871c91847a01df3bbfd83006d2fee22e2bc52d.
This broke one of our tests.
Matthias Clasen [Thu, 22 Dec 2022 13:31:26 +0000 (13:31 +0000)]
Merge branch 'gtk-3-24-clipboard_eol' into 'gtk-3-24'
clipboard: improve EOL conversion of plain text
See merge request GNOME/gtk!5366
Ignazio Pillai [Thu, 22 Dec 2022 09:20:20 +0000 (10:20 +0100)]
clipboard: improve EOL conversion of plain text
Handle the case of clipboard text with CR line endings
Matthias Clasen [Tue, 20 Dec 2022 02:19:39 +0000 (02:19 +0000)]
Merge branch 'wip/gtk3-fix-delete-surrounding' into 'gtk-3-24'
[GTK3] gtkimcontextwayland: Convert byte based offset to char based offset in delete_surrounding_text
See merge request GNOME/gtk!5255
Alynx Zhou [Thu, 24 Nov 2022 10:35:47 +0000 (18:35 +0800)]
gtkimcontextwayland: Convert byte based offset to char based offset in delete_surrounding_text
ClutterInputFocus/GtkIMContext uses char based offset for
delete_surrounding, however, text_input_v3 uses byte based offset for
it. Currently only GTK with mutter can work correctly via text_input_v3
because they both forget to convert between char based offset and byte
based offset.
This commit fixes it in GTK by converting byte based offset to char
based offset with the UTF-8 encoded surrounding text.
Fixes <https://gitlab.gnome.org/GNOME/gtk/-/issues/4566>.
Danial Behzadi [Wed, 14 Dec 2022 12:32:57 +0000 (12:32 +0000)]
Update Persian translation
Matthias Clasen [Wed, 14 Dec 2022 11:04:08 +0000 (11:04 +0000)]
Merge branch 'revert-cursor-changes-3-24' into 'gtk-3-24'
Revert "wayland: Look for cursor themes in $HOME"
See merge request GNOME/gtk!5329
Matthias Clasen [Tue, 13 Dec 2022 23:52:34 +0000 (18:52 -0500)]
Revert "Revert "wayland/cursor: Sanity check cursor image size""
This reverts commit
4432a037429d8f7d272c58747967d82f3bd563b9.
Matthias Clasen [Tue, 13 Dec 2022 23:52:29 +0000 (18:52 -0500)]
Revert "Make wayland load cursors on demand"
This reverts commit
66a199806ceb3daa5e2c7d3a5b45a86007cec46a.
Matthias Clasen [Tue, 13 Dec 2022 23:51:16 +0000 (18:51 -0500)]
Revert "wayland: Look for cursor themes in $HOME"
This reverts commit
3f1536632f682c355d0c3abe1afc80cf975c2cce.
Matthias Clasen [Tue, 13 Dec 2022 13:00:36 +0000 (13:00 +0000)]
Merge branch 'gtk3_fix_chooser_dead_tilde_trigger_location' into 'gtk-3-24'
Fix open location entry when pressing '~'
See merge request GNOME/gtk!4971
Matthias Clasen [Tue, 13 Dec 2022 12:10:34 +0000 (12:10 +0000)]
Merge branch 'ebassi/no-more-autotools-redux' into 'gtk-3-24'
Drop the Autotools build
See merge request GNOME/gtk!5299
Emmanuele Bassi [Mon, 12 Dec 2022 13:32:03 +0000 (13:32 +0000)]
Merge branch 'basename' into 'gtk-3-24'
Use @basename@ in enumeration type templates
See merge request GNOME/gtk!5324
Ross Burton [Mon, 12 Dec 2022 13:09:26 +0000 (13:09 +0000)]
Use @basename@ in enumeration type templates
The @filename@ directive will use the full path of the file being parsed
for enumeration types; we should use @basename@, instead, as it improves
the reproducibility of the build by using only the file name.
Backport of
4040f76529bbf6d3310a71df2d37c9d95af83892 from main.
Matthias Clasen [Sun, 11 Dec 2022 04:02:14 +0000 (04:02 +0000)]
Merge branch 'issue5305' into 'gtk-3-24'
[quartz] Work around macOS 13 not sending trackingArea events.
See merge request GNOME/gtk!5280
Matthias Clasen [Sun, 11 Dec 2022 04:02:00 +0000 (04:02 +0000)]
Merge branch 'issue5393' into 'gtk-3-24'
[quartz] Set GdkQuartzView wantsLayer.
See merge request GNOME/gtk!5309
Olga Smirnova [Fri, 9 Dec 2022 17:44:15 +0000 (17:44 +0000)]
Add Interlingue translation
Olga Smirnova [Fri, 9 Dec 2022 17:43:35 +0000 (17:43 +0000)]
Add Interlingue translation
Chun-wei Fan [Fri, 9 Dec 2022 04:41:10 +0000 (12:41 +0800)]
meson: Clean up FreeType2 dependency search
Since we are using Meson 0.60.x now, make use of CMake's support for finding
FreeType in addition to pkg-config, which actually looks for FreeType2 via
looking at the headers and .lib's internally, so we don't have to reinvent
the wheel.
Sadly, we don't have similar support for Cairo and HarfBuzz in CMake, so we
have to stick with what we have now, since we still need to support older
HarfBuzz and Cairo versions as we are in a stable release series.
Chun-wei Fan [Fri, 9 Dec 2022 04:08:32 +0000 (12:08 +0800)]
README.win32.md: Update build instructions
Adapt the build instructions to reflect the change to building with
Meson only, and list the dependencies in a clearer list with the additional
tools that are needed to build them with Visual Studio.
Update the list of dependencies and their optional features that are needed to
enable optional features in the GTK build itself.
Luca Bacci [Thu, 8 Dec 2022 18:08:27 +0000 (18:08 +0000)]
Remove GTK version / interface age macros in config.h
They are present in gtk/gtkversion.h. This avoids macro redefinition
warnings.
Luca Bacci [Thu, 8 Dec 2022 18:07:21 +0000 (18:07 +0000)]
Remove config.h.meson
Meson can generate a configuration file better than a human can.
John Ralls [Thu, 8 Dec 2022 18:04:56 +0000 (10:04 -0800)]
[quartz] Set GdkQuartzView wantsLayer.
Apparently wantsUpdateLayer by itself isn't sufficient.
Also #ifdef wantsUpdateLayer for macOS X 10.8 and later; earlier
versions don't provide it.
Fixes #5393
Emmanuele Bassi [Thu, 8 Dec 2022 18:04:05 +0000 (18:04 +0000)]
docs: Remove the separate commit document
It's part of the contribution guide.
Emmanuele Bassi [Thu, 8 Dec 2022 18:03:52 +0000 (18:03 +0000)]
docs: Remove old, pre-1.0 news file
Emmanuele Bassi [Thu, 8 Dec 2022 18:02:39 +0000 (18:02 +0000)]
docs: Remove outdated files
The maintainers are listed in the DOAP file, and the authors are listed
in the commits history.
Emmanuele Bassi [Thu, 8 Dec 2022 18:01:55 +0000 (18:01 +0000)]
docs: Replace HACKING with a contribution guide
The HACKING file is woefully out of date.
Emmanuele Bassi [Thu, 8 Dec 2022 12:25:51 +0000 (12:25 +0000)]
docs: Update the build instructions
Emmanuele Bassi [Thu, 8 Dec 2022 12:05:33 +0000 (12:05 +0000)]
docs: Update the README
Emmanuele Bassi [Thu, 8 Dec 2022 12:00:59 +0000 (12:00 +0000)]
docs: Update the installation instructions
Matthias Clasen [Thu, 8 Dec 2022 13:10:53 +0000 (13:10 +0000)]
Merge branch 'emoji-recent-empty' into 'gtk-3-24'
emojichooser: Actually disable the recent section
See merge request GNOME/gtk!5307
Matthias Clasen [Thu, 8 Dec 2022 12:14:55 +0000 (12:14 +0000)]
Merge branch 'backport-mr-5088-to-gtk-3-24' into 'gtk-3-24'
Treat XKB_MOD_NAME_LOGO as super key
See merge request GNOME/gtk!5304
Guido Günther [Wed, 7 Dec 2022 18:26:29 +0000 (19:26 +0100)]
emojichooser: Actually disable the recent section
The loop sets empty = FALSE when there are emojis but for that
to work we need to initialize the value to TRUE initially.
Fixes: 7928532bc5c33b2c6a10bae138ebc6dca1843cb0
(cherry picked from commit
89c816a614db4083e80862b631f4b3e44aa17eae)
Matthias Clasen [Thu, 8 Dec 2022 12:10:30 +0000 (12:10 +0000)]
Merge branch 'wip/carlosg/convert-mimetypes-to-atoms' into 'gtk-3-24'
gdk/wayland: Convert selection mimetypes back to atoms, if needed
See merge request GNOME/gtk!5300
Emmanuele Bassi [Tue, 6 Dec 2022 22:49:42 +0000 (22:49 +0000)]
build: Remove the Autotools build
CI and downstream packagers have been using the Meson build for a while
now, and we checked that it's idempotent to the Autotools build.
Having two build systems in tree doesn't make maintaining and releasing
GTK any easier, even if it's the stable/frozen branch.
Emmanuele Bassi [Thu, 8 Dec 2022 11:35:50 +0000 (11:35 +0000)]
build: Conditionally generate introspection
We not only want to use the "introspection" option: we also want to
avoid building when cross-compiling, and if the introspection tools
are not available.
GTK's main development branch already has a fairly well tested check, so
let's backport it.
Po Lu [Mon, 19 Sep 2022 07:57:58 +0000 (15:57 +0800)]
Treat XKB_MOD_NAME_LOGO as super key
Based on !5088. See also #4913.
Carlos Garnacho [Tue, 6 Dec 2022 23:35:37 +0000 (00:35 +0100)]
gdk/wayland: Convert selection mimetypes back to atoms, if needed
Commit
0c1ea922197 took care of converting STRING/UTF8_STRING to mimetype
strings when letting selection targets known to the outer world through
wl_data_source/zwp_primary_selection_source_v1, but it missed the conversion
of those mimetypes back to the old atom strings, depending on the
application, the mimetype counterparts might not be known or handled, so
requests to paste from this app could go ignored.
Fixes: 0c1ea922197 - wayland: Translate STRING/UTF8_STRING selection atoms to mimetypes
Closes: https://gitlab.gnome.org/GNOME/gtk/-/issues/5397
Emmanuele Bassi [Tue, 6 Dec 2022 22:21:43 +0000 (22:21 +0000)]
ci: Dist using Meson
Emmanuele Bassi [Tue, 6 Dec 2022 22:13:23 +0000 (22:13 +0000)]
docs: Update installation instructions
Mention Meson.
Emmanuele Bassi [Tue, 6 Dec 2022 22:01:51 +0000 (22:01 +0000)]
x11: Remove unused header file
The XInput 1.x support was removed 10 years ago.
Emmanuele Bassi [Tue, 6 Dec 2022 21:57:21 +0000 (21:57 +0000)]
broadway: Remove unused file
Emmanuele Bassi [Tue, 6 Dec 2022 21:49:22 +0000 (21:49 +0000)]
Use the right type when calling GtkWidget methods
Let's avoid complaints from the compiler.
Emmanuele Bassi [Tue, 6 Dec 2022 21:47:25 +0000 (21:47 +0000)]
Add missing annotation for GdkAtom
Emmanuele Bassi [Tue, 6 Dec 2022 21:45:33 +0000 (21:45 +0000)]
Use the same argument name in the header and source files
They must match so the introspection scanner can do its job.
Emmanuele Bassi [Tue, 6 Dec 2022 21:42:55 +0000 (21:42 +0000)]
Remove unnecessary gitignore file
The .gitignore file is only needed for the Autotools build, and it gets
generated by git.mk, so we don't need to have the file in the
repository.
Emmanuele Bassi [Tue, 6 Dec 2022 21:41:29 +0000 (21:41 +0000)]
wayland: Fix argument's constness
The compiler was pointing out we were dropping the const modifier.
Emmanuele Bassi [Tue, 6 Dec 2022 21:30:56 +0000 (21:30 +0000)]
Drop unnecessary volatile modifier
It's completely useless, and just generates compiler warnings with
recent GLib versions.
Emmanuele Bassi [Tue, 6 Dec 2022 21:29:38 +0000 (21:29 +0000)]
build: Don't dist generated example files with Autotools
The generated resources.c file should not be part of the dist tarball.
Emmanuele Bassi [Tue, 6 Dec 2022 21:15:48 +0000 (21:15 +0000)]
build: Drop Meson version checks
We depend on a new enough version of Meson.
Emmanuele Bassi [Tue, 6 Dec 2022 21:07:30 +0000 (21:07 +0000)]
build: Add missing 512 icons to the Autotools build
Emmanuele Bassi [Tue, 6 Dec 2022 20:48:24 +0000 (20:48 +0000)]
build: Use a recent version of Meson
And fix the project name, while we're at it.
Emmanuele Bassi [Tue, 6 Dec 2022 20:47:55 +0000 (20:47 +0000)]
build: Add missing argument to add_languages()
We need to specify whether we want a native compiler or not.
Emmanuele Bassi [Tue, 6 Dec 2022 20:45:58 +0000 (20:45 +0000)]
build: Replace deprecated get_pkgconfig_variable()
Use get_variable(pkgconfig:...) instead.
Matthias Clasen [Sat, 3 Dec 2022 23:11:02 +0000 (23:11 +0000)]
Merge branch 'backport-mr-5148-to-gtk-3-24' into 'gtk-3-24'
label: Tweak selection behavior
See merge request GNOME/gtk!5289
Matthias Clasen [Sat, 3 Dec 2022 10:16:50 +0000 (11:16 +0100)]
label: Tweak selection behavior
Arrange for double-click-followed-by-drag to do
select by words, not select-and-dnd. This matches
the behavior in GtkTextView better and feels
intuitive.
Fixes: #2024
Asier Sarasua Garmendia [Sat, 3 Dec 2022 09:44:45 +0000 (09:44 +0000)]
Update Basque translation
Nart Tlisha [Fri, 2 Dec 2022 10:50:36 +0000 (10:50 +0000)]
Add Abkhazian translation
Nart Tlisha [Fri, 2 Dec 2022 10:15:27 +0000 (10:15 +0000)]
Update Abkhazian translation
Matthias Clasen [Wed, 30 Nov 2022 23:35:56 +0000 (23:35 +0000)]
Merge branch 'example-links' into 'gtk-3-24'
Update links to current versions
See merge request GNOME/gtk!5283
Guido Günther [Wed, 30 Nov 2022 08:59:33 +0000 (09:59 +0100)]
docs: Use main branch instead of master
The old name still works but let's use the current name.
Guido Günther [Wed, 30 Nov 2022 08:57:38 +0000 (09:57 +0100)]
docs: Switch example to gtk-3-24 branch
Let's use recent examples.
Guido Günther [Wed, 30 Nov 2022 08:54:32 +0000 (09:54 +0100)]
application: Switch links to gtk-3-24 branch
`master` doesn't exist anymore and we want to refer to a GTK3 example
John Ralls [Sun, 20 Nov 2022 00:25:28 +0000 (16:25 -0800)]
[quartz] Work around macOS 13 not sending trackingArea events.
Fixes #5305
John Ralls [Tue, 29 Nov 2022 19:44:27 +0000 (11:44 -0800)]
[quartz] Update known and latest macOS version to macOS 13 Ventura.
John Ralls [Tue, 29 Nov 2022 18:12:18 +0000 (10:12 -0800)]
[quartz]Use new (since 10.5) NSTrackingArea instead of older tracking rect.
John Ralls [Tue, 29 Nov 2022 18:17:05 +0000 (10:17 -0800)]
[quartz] Fix some compile warnings.
Rafael Fontenelle [Mon, 28 Nov 2022 12:13:58 +0000 (12:13 +0000)]
Update Brazilian Portuguese translation
Matthias Clasen [Fri, 25 Nov 2022 14:42:47 +0000 (14:42 +0000)]
Merge branch 'backport-mr-3708-to-gtk-3-24' into 'gtk-3-24'
wayland: Look for cursor themes in $HOME
See merge request GNOME/gtk!5262
Matthias Clasen [Tue, 29 Jun 2021 20:57:15 +0000 (16:57 -0400)]
wayland: Look for cursor themes in $HOME
We should look in the same places that libXcursor does,
so add $XDG_DATA_HOME/icons and $HOME/.icons to the list.
Fixes: #4080
Simon McVittie [Thu, 24 Nov 2022 13:42:53 +0000 (13:42 +0000)]
Merge branch 'wip/smcv/xfail-gtk3' into 'gtk-3-24'
[GTK 3] testsuite: Avoid using should_fail
See merge request GNOME/gtk!5249
Simon McVittie [Wed, 23 Nov 2022 21:26:50 +0000 (21:26 +0000)]
testsuite: Don't create .test files for flaky or failing tests
These tests can be run manually, but are not suitable for use as an
acceptance test, so let's not make frameworks like Debian's autopkgtest
run these when they run ginsttest-runner in the most obvious way.
a11ytests.test doesn't seem to be reliable enough to be used as a QA
acceptance criterion, and has been disabled as a build-time test in both
Gitlab-CI and Debian since 2019. a11ystate.test is not set up to be run
at build time at all, and has been marked as flaky on ci.debian.net
since 2018.
The rest of the testsuite/a11y directory seems to have been
reliable in practice, at least on ci.debian.net, so try leaving them
enabled as installed-tests.
In principle this could be made finer-grained by having a separate .test
file and a separate Meson test() for each .ui file, but that would
require more active maintenance of GTK 3.
Signed-off-by: Simon McVittie <smcv@debian.org>
Simon McVittie [Thu, 24 Nov 2022 12:09:12 +0000 (12:09 +0000)]
testsuite: Try enabling a11y tests, other than those known to be unstable
At least some of the tests implemented via the accessibility-dump
executable are known to be unstable, but the tests based on separate
executables (tree-performance.c, etc.) have been reasonably consistently
passing on ci.debian.net for several years, so hopefully they are also
reliable enough for upstream CI and we don't need to mark them as flaky?
Signed-off-by: Simon McVittie <smcv@debian.org>
Jordi Mas [Wed, 23 Nov 2022 21:29:34 +0000 (22:29 +0100)]
Update Catalan translation
Simon McVittie [Wed, 23 Nov 2022 18:36:08 +0000 (18:36 +0000)]
testsuite: Avoid using should_fail
There are two possible interpretations of "expected failure": either
the test *must* fail (exactly the inverse of an ordinary test, with
success becoming failure and failure becoming success), or the test
*may* fail (with success intended, but failure possible in some
environments). Autotools had the second interpretation, which seems
more useful in practice, but Meson has the first.
In GTK 3.24.35, if the environment is such that the label-sizing.ui
reftest happens to be successful, the overall result of the test suite
is failure. This seems unlikely to have been the intention.
Instead of using should_fail, put the tests in one of two new suites:
"flaky" is intended for tests that succeed or fail unpredictably
according to the test environment or chance, while "failing" is for
tests that ought to succeed but currently never do as a result of a
bug or missing functionality. With a sufficiently new version of Meson,
the flaky and failing tests are not run by default, but can be requested
with a command like:
meson test --setup=unstable_tests --suite=flaky --suite=failing
This arrangement is inspired by GNOME/glib!2987, which was contributed
by Marco Trevisan.
Signed-off-by: Simon McVittie <smcv@debian.org>
Emmanuele Bassi [Wed, 23 Nov 2022 12:07:08 +0000 (12:07 +0000)]
Merge branch 'gtk-issue-4456' into 'gtk-3-24'
Flush drawable surface when getting a pixbuf
See merge request GNOME/gtk!5244